Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustments #152

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Minor adjustments #152

merged 6 commits into from
Feb 18, 2025

Conversation

SunnysideAaron
Copy link
Contributor

Most of my notes are on my commit history. The biggest things I think someone needs a hard check on:

  • the Italian and Japanese translations. I don't speak those languages. Did the best I could with google translate.
  • the new blog entry directing people to github and slack. Someone with more skin in the game on this project might want to do that different.

Why:
I had heard good things about Goa. Was evaluating it for my next project today. Came to https://goa.design/ and saw that according to the blog the last version of Goa was released in March 2021. I still wanted to dig deeper. Somehow through google I came to the GitHub project of the Goa website instead of the Goa project. They have very similar names / urls and being new to the Goa I had no idea I wasn't on the main project. It isn't until far down the fold that there is any mention of website. The website doesn't have any releases, far fewer contributors, and most committed files are years old. This led me to believe the Goa project might be abandoned / dead. Luckily I was curious enough to want to confirm that. I signed up for the slack channel and boom! A living vibrant community.

Even if this request is denied the entry points into the project need adjustment.

aaronrshort2 added 5 commits February 6, 2025 21:20
ERROR the "date" front matter field is not a parsable date: see C:\Working\goa.design\content\implement\error_handling.it.md
ERROR the "date" front matter field is not a parsable date: see C:\Working\goa.design\content\implement\error_handling.ja.md
ERROR the "date" front matter field is not a parsable date: see C:\Working\goa.design\content\implement\error_handling.md

I'm guessing some previous version of a dependancy didn't care as much as it does now.
WARNING I do not speak Italian or Japanese. I used google translate on the sentence.
* adding v3 differences
WARNING I do not speak itallian or japanese. Used google translate.
…ub project and they are buried.

Changing repo to repository. Abbreviations should be avoided if possilbe to avoid confusion.

WARNING. I do not speak Italian or Japanese. I used google translate
…is years old. Makes the Goa project look abandoned. Someone probably wants to do this differently. Did not want to just create a new dated entry since that would also grow out of date.

WARNING I do not speak Italian or Japanese. Used google translate.
@raphael
Copy link
Member

raphael commented Feb 7, 2025

This is great, thank you. My vote would be to remove the blog section altogether as it hasn't been kept up-to-date and to your point can be misleading. The other changes look good.

@SunnysideAaron
Copy link
Contributor Author

There is a lot of good historical information there. It is a good quick view of how the project got to this point. Is all the information there already documented other places? Perhaps if the last entry was just a message about "we have stopped blogging, for now, see ...."

@SunnysideAaron
Copy link
Contributor Author

If you don't like that idea and still want the blog cut I can make that change.

@tchssk
Copy link
Member

tchssk commented Feb 8, 2025

I noticed this issue earlier but forgot to suggest a solution.

After the blog stopped updating, updates were posted on several other platforms, including X (Twitter), Slack, Medium, and Patreon, as far as I know. We can repost those updates on the blog.

Of course, it's a bit of a hassle.

@raphael
Copy link
Member

raphael commented Feb 8, 2025

Related: I'm working on a refreshed version of the site (see the v2 branch and the new contents). We can decide to remove or keep the blog section there (I had removed it initially). If we keep it we'll need to make sure to keep it up-to-date :)

…he blog is years old. Makes the Goa project look abandoned. Someone probably wants to do this differently. Did not want to just create a new dated entry since that would also grow out of date."

This reverts commit b1caf69.
@SunnysideAaron SunnysideAaron changed the title Minor adjustments, new blog entry Minor adjustments Feb 9, 2025
@SunnysideAaron
Copy link
Contributor Author

Removed the blog adjustment. Should just be a few minor adjustments now. Let me know if there is anything else that needs changing.

@raphael
Copy link
Member

raphael commented Feb 16, 2025

Thank you, maybe @tchssk wants to review the Japanese translation?

Copy link
Member

@tchssk tchssk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested some changes.

(If possible, could you please review it? @ikawaha)

Comment on lines +11 to +14
Goa は GitHub を使用しています。プロジェクトは次の場所にあります。
[github.com/goadesign/goa](https://github.com/goadesign/goa)。
このサイトのプロジェクトと混同しないでください
[github.com/goadesign/goa.design](https://github.com/goadesign/goa.design)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Goa は GitHub を使用しています。プロジェクトは次の場所にあります。
[github.com/goadesign/goa](https://github.com/goadesign/goa)
このサイトのプロジェクトと混同しないでください
[github.com/goadesign/goa.design](https://github.com/goadesign/goa.design)
Goa は GitHub を使用しています。プロジェクトは [github.com/goadesign/goa](https://github.com/goadesign/goa) にあります。
このサイトのプロジェクト [github.com/goadesign/goa.design](https://github.com/goadesign/goa.design) と混同しないでください。

Comment on lines +21 to +22
v2 以降、Goa の DSL により、トランスポートでサービスを記述することが可能になりました。
不可知論的な方法。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
v2 以降、Goa の DSL により、トランスポートでサービスを記述することが可能になりました。
不可知論的な方法。
v2 以降の Goa DSL はトランスポートにとらわれない方法でサービスを記述することを可能にしています。


## Goa v3 は v2 とどう違う?

* Goa v3 は Go モジュールを必要とし、サポートします。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Goa v3 は Go モジュールを必要とし、サポートします
* Goa v3 は Go モジュールをサポートしています

@ikawaha
Copy link
Contributor

ikawaha commented Feb 16, 2025

@tchssk LGTM 👍

@raphael
Copy link
Member

raphael commented Feb 18, 2025

Thank you both!

@raphael raphael merged commit 15c3fba into goadesign:master Feb 18, 2025
@tchssk
Copy link
Member

tchssk commented Feb 18, 2025

The suggested changes have not been commited yet.
I'll make it a new pull request.

@tchssk tchssk mentioned this pull request Feb 18, 2025
@raphael
Copy link
Member

raphael commented Feb 19, 2025

Whoops, sorry for jumping the gun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants