Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: Add documentation for Drupal #12925

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justafish
Copy link

Details

Adds documentation for authentication with Drupal


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@justafish justafish requested a review from a team as a code owner February 3, 2025 14:02
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 649313d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67a226e636688e0008cf9e68

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 649313d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67a226e65764ed0008c6a84b
😎 Deploy Preview https://deploy-preview-12925--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu BeryJu changed the title Add documentation for Drupal website/integrations: Add documentation for Drupal Feb 3, 2025
Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution. Before reviewing this PR, would it be possible to make sure your contribution follows the template outlined in the documentation? Thanks.

@justafish
Copy link
Author

@dominic-r I've made this change (however the authentik configuration needs to happen before the Drupal configuration)

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @justafish . Thanks for your contribution. Here are a few comments. Please do let me know if you have any questions.


## What is Drupal

> [Drupal](https://new.drupal.org/home) is a free and open-source content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't link Drupal's home page in markdown and link it's wikipedia page right below. Please only keep Line 15

- Create an application e.g. "Drupal" and set the Provider field to the provider
created above

### 2FA (optional)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is not needed


The following placeholders are used in this guide:

- `drupal.ddev.site` is the FQDN of Drupal installation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drupal can be selfhosted. As a result, it is not fair to say that drupal.ddev.site is it's FQDN. You could instead say drupal.company and update all further references

The following placeholders are used in this guide:

- `drupal.ddev.site` is the FQDN of Drupal installation.
- `authentik.company` is the FQDN of Authentik installation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"authentik" should be in lowercase as per the style guide's "authentik names" section

:::


## authentik configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to tana: reminder: will update format in a later PR

"Configuration stages"
![](./drupal_2fa.png)

## Service configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Service configuration
## Drupal configuration

"Configuration stages"
![](./drupal_2fa.png)

## Service configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the style guide's "formatting" section for proper URL styling

Once logged in for the first time, depending on your user registration settings
you may get a message saying you've successfully logged in but your account is
blocked and needs to be approved by an administrator, so unblock the user in the
usual way, and then you can log in successfully.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the usual way

How? Could you link documentation which references this unblock method?

- Select the "Override registration settings" checkbox
- Enable the OpenID button on user login form

## Configuration verification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration verification section is a step to confirm that authentik works with the service. You need to explicitly mention how to log in & if there are any particularities. I suggest looking at the Integration template's example for a good base

"Configuration stages"
![](./drupal_2fa.png)

## Service configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"x endpoint" & "if authentik is running locally [...]" lines could be consolidated into one, potentially with a message at the top of this configuration. I suggest looking at the style guide's admonitions syntax section for the correct markdown format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants