Improve JSON serialization perf of longer strings on mono (dotnet#39733)

godspeedu · Aug 14, 2020 · ac492c9 · ac492c9
1 parent a2908e3
commit ac492c9
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/...em.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultJavaScriptEncoderBasicLatin.cs b/...em.Text.Encodings.Web/src/System/Text/Encodings/Web/DefaultJavaScriptEncoderBasicLatin.cs
@@ -103,11 +103,19 @@ public override unsafe int FindFirstCharacterToEncode(char* text, int textLength
 #endif
             Debug.Assert(textLength > 0 && ptr < end);
 
+            // For performance on the Mono interpreter, avoid referencing the static table for every value.
+            ReadOnlySpan<byte> allowListLocal = AllowList;
+
             do
             {
                 Debug.Assert(text <= ptr && ptr < (text + textLength));
 
-                if (NeedsEscaping(*(char*)ptr))
+                char value = *(char*)ptr;
+
+                // NeedsEscaping() is lifted below for perf; verify semantics remain consistent.
+                Debug.Assert((value > LastAsciiCharacter || allowListLocal[value] == 0) == NeedsEscaping(value));
+
+                if (value > LastAsciiCharacter || allowListLocal[value] == 0)
                 {
                     goto Return;
                 }
@@ -276,11 +284,17 @@ public override unsafe int FindFirstCharacterToEncodeUtf8(ReadOnlySpan<byte> utf
 #endif
                 Debug.Assert(textLength > 0 && ptr < end);
 
+                // For performance on the Mono interpreter, avoid referencing the static table for every value.
+                ReadOnlySpan<byte> allowListLocal = AllowList;
+
                 do
                 {
                     Debug.Assert(pValue <= ptr && ptr < (pValue + utf8Text.Length));
 
-                    if (NeedsEscaping(*ptr))
+                    // NeedsEscaping() is lifted below for perf; verify semantics remain consistent.
+                    Debug.Assert((allowListLocal[*ptr] == 0) == NeedsEscaping(*ptr));
+
+                    if (allowListLocal[*ptr] == 0)
                     {
                         goto Return;
                     }