mtd: pxa3xx_nand: Fix blank page ECC mismatch

This bug was introduced in f8155a4 ("mtd: pxa3xx_nand: rework irq logic") and causes the PXA3xx NAND controller fail to operate with NAND flash that has empty pages. According to the comment in this block, the hardware controller will report a double-bit error for empty pages, which can and must be ignored. This patch restores the original behaviour of the driver. Signed-off-by: Daniel Mack <[email protected]> Acked-by: Lei Wen <[email protected]> Cc: Haojian Zhuang <[email protected]> Cc: David Woodhouse <[email protected]> Cc: [email protected] [2.6.38+] Signed-off-by: Artem Bityutskiy <[email protected]>
goeke · Sep 11, 2011 · 543e32d · 543e32d
1 parent 0fab028
commit 543e32d
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
@@ -685,6 +685,8 @@ static int pxa3xx_nand_read_page_hwecc(struct mtd_info *mtd,
 		 * OOB, ignore such double bit errors
 		 */
 		if (is_buf_blank(buf, mtd->writesize))
+			info->retcode = ERR_NONE;
+		else
 			mtd->ecc_stats.failed++;
 	}