forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Coccinelle: Find doubled arguments to boolean or bit operators.
Signed-off-by: Julia Lawall <[email protected]> Signed-off-by: Nicolas Palix <[email protected]> Signed-off-by: Michal Marek <[email protected]>
- Loading branch information
Showing
2 changed files
with
94 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /// Find bit operations that include the same argument more than once | ||
| //# One source of false positives is when the argument performs a side | ||
| //# effect. Another source of false positives is when a neutral value | ||
| //# such as 0 for | is used to indicate no information, to maintain the | ||
| //# same structure as other similar expressions | ||
| /// | ||
| // Confidence: Moderate | ||
| // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. | ||
| // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. | ||
| // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. | ||
| // URL: http://coccinelle.lip6.fr/ | ||
| // Comments: | ||
| // Options: -no_includes -include_headers | ||
|
|
||
| virtual context | ||
| virtual org | ||
| virtual report | ||
|
|
||
| @r expression@ | ||
| expression E; | ||
| position p; | ||
| @@ | ||
|
|
||
| ( | ||
| * E@p | ||
| & ... & E | ||
| | | ||
| * E@p | ||
| | ... | E | ||
| | | ||
| * E@p | ||
| & ... & !E | ||
| | | ||
| * E@p | ||
| | ... | !E | ||
| | | ||
| * !E@p | ||
| & ... & E | ||
| | | ||
| * !E@p | ||
| | ... | E | ||
| ) | ||
|
|
||
| @script:python depends on org@ | ||
| p << r.p; | ||
| @@ | ||
| cocci.print_main("duplicated argument to & or |",p) | ||
| @script:python depends on report@ | ||
| p << r.p; | ||
| @@ | ||
| coccilib.report.print_report(p[0],"duplicated argument to & or |") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /// Find &&/|| operations that include the same argument more than once | ||
| //# A common source of false positives is when the argument performs a side | ||
| //# effect. | ||
| /// | ||
| // Confidence: Moderate | ||
| // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. | ||
| // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. | ||
| // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. | ||
| // URL: http://coccinelle.lip6.fr/ | ||
| // Comments: | ||
| // Options: -no_includes -include_headers | ||
|
|
||
| virtual context | ||
| virtual org | ||
| virtual report | ||
|
|
||
| @r expression@ | ||
| expression E; | ||
| position p; | ||
| @@ | ||
|
|
||
| ( | ||
| * E@p | ||
| || ... || E | ||
| | | ||
| * E@p | ||
| && ... && E | ||
| ) | ||
|
|
||
| @script:python depends on org@ | ||
| p << r.p; | ||
| @@ | ||
| cocci.print_main("duplicated argument to && or ||",p) | ||
| @script:python depends on report@ | ||
| p << r.p; | ||
| @@ | ||
| coccilib.report.print_report(p[0],"duplicated argument to && or ||") |