Skip to content

Commit

Permalink
jbd: Use WRITE_SYNC in journal checkpoint.
Browse files Browse the repository at this point in the history
In journal checkpoint, we write the buffer and wait for its finish.
But in cfq, the async queue has a very low priority, and in our test,
if there are too many sync queues and every queue is filled up with
requests, and the process will hang waiting for the log space.

So this patch tries to use WRITE_SYNC in __flush_batch so that the request will
be moved into sync queue and handled by cfq timely. We also use the new plug,
sot that all the WRITE_SYNC requests can be given as a whole when we unplug it.

Reported-by: Robin Dong <[email protected]>
Signed-off-by: Tao Ma <[email protected]>
Signed-off-by: Jan Kara <[email protected]>
  • Loading branch information
taoma-tm authored and jankara committed Jun 27, 2011
1 parent bb18924 commit a212d1a
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion fs/jbd/checkpoint.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <linux/jbd.h>
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/blkdev.h>
#include <trace/events/jbd.h>

/*
Expand Down Expand Up @@ -257,9 +258,12 @@ static void
__flush_batch(journal_t *journal, struct buffer_head **bhs, int *batch_count)
{
int i;
struct blk_plug plug;

blk_start_plug(&plug);
for (i = 0; i < *batch_count; i++)
write_dirty_buffer(bhs[i], WRITE);
write_dirty_buffer(bhs[i], WRITE_SYNC);
blk_finish_plug(&plug);

for (i = 0; i < *batch_count; i++) {
struct buffer_head *bh = bhs[i];
Expand Down

0 comments on commit a212d1a

Please sign in to comment.