fuse: prevent fuse_put_request on invalid pointer

fuse_direct_io() has a loop where requests are allocated in each iteration. if allocation fails, the loop is broken out and follows into an unconditional fuse_put_request() on that invalid pointer. Signed-off-by: Anand V. Avati <[email protected]> Signed-off-by: Miklos Szeredi <[email protected]> Cc: [email protected]
goeke · Nov 4, 2009 · f60311d · f60311d
1 parent b419148
commit f60311d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
@@ -1063,7 +1063,8 @@ ssize_t fuse_direct_io(struct file *file, const char __user *buf,
 				break;
 		}
 	}
-	fuse_put_request(fc, req);
+	if (!IS_ERR(req))
+		fuse_put_request(fc, req);
 	if (res > 0)
 		*ppos = pos;