Remove lingering references to KProxy #158
Conversation
| class SingKind k where | ||
| type DemoteRep k :: * | ||
| fromSing :: Sing (a :: k) -> DemoteRep k | ||
| toSing :: DemoteRep k -> SomeSing k | ||
|
|
||
| This class is used to convert a singleton value back to a value in the | ||
| original, unrefined ADT. The `fromSing` method converts, say, a |
There was a problem hiding this comment.
Further down, this says:
The
DemoteRepassociated
kind-indexed type family maps a proxy of the kindNat
back to the typeNat.
This is no longer true, but I'm not sure what I should change this to. Should I just say "maps Nat to Nat"? I don't know if that really elucidates what the purpose of DemoteRep is. Maybe we ought to give an example where DemoteRep k /= k? (Speaking of which, should the default definition of DemoteRep be DemoteRep k = k?)
There was a problem hiding this comment.
The obvious example where DemoteRep k /= k is TyFun with ->.
There was a problem hiding this comment.
True. However, I just realized that it still makes sense to distinguish between the kind-level Nat and the type-level Nat (between which DemoteRep facilitates the transition), so I simply updated the description to state that.
|
Urk, the Travis build failed due to |
|
There we go, the build is green now. All good to go. |
|
Hooray! |
#148 removed uses of
KProxyfrom the codebase, but it's still lurking in a couple of places:ByHand2testData.Promotion.Prelude.Enum. Since it's outdated, I opted to remove the whole comment (and the unnecessary-fno-warn-orphansflag).README. But see my inline comment.