Fix #167 #168
Merged
Fix #167 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me. Thanks for submitting the patch, and for including the test case! Will merge if Travis approves (but may not be until morning, as I'm stopping work for the night now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix #167. I noticed that in the code for singling instance declarations (
singInstDinData.Singletons.Single), there's a case in whichsingletonsfails to look up a singled function name and instead resorts to callingdsReifyagain. But after this call todsReify, it uses the reified function type signature without expanding through type synonyms! Adding a call toexpandafterwards seems to do the trick.