fw_update: add package name Kconfig symbol #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 448a9dd): https://golioth-firmware-sdk-doxygen-dev--pr711-szczys-kconfig-qb8cij7g.web.app (expires Tue, 14 Jan 2025 19:32:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
szczys
force-pushed
the
szczys/kconfig-option-fw-updage-package-name
branch
from
f9046b4 to
6ab9a76
Compare
Code Coverage
|
Codecov ReportAttention: Patch coverage is
|
sam-golioth
reviewed
Dec 31, 2024
| default "main" | ||
| help | ||
| The Package Name used by the Golioth Cloud to indicate the binary to use for device firmware | ||
| update. This name must be no more than GOLIOTH_OTA_MAX_PACKAGE_NAME_LEN characters in length. |
There was a problem hiding this comment.
Let's add a static assert to enforce this
There was a problem hiding this comment.
Great suggestion, thanks!
szczys
force-pushed
the
szczys/kconfig-option-fw-updage-package-name
branch
2 times, most recently
from
61b8b3d to
1fcd5ac
Compare
sam-golioth
approved these changes
Jan 2, 2025
Add GOLIOTH_FW_UPDATE_PACKAGE_NAME kconfig symbol. Previously the package name used by the fw_update module was hardcoded in the header file. Make this value configurable so it may be used programmatically at build time. Signed-off-by: Mike Szczys <[email protected]>
Initialize status variable during declaration to avoid it being used uninitialized. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/kconfig-option-fw-updage-package-name
branch
from
1fcd5ac to
448a9dd
Compare
mniestroj
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Kconfig symbol: CONFIG_GOLIOTH_FW_UPDATE_PACKAGE_NAME
Previously the package name used by the fw_update module was hardcoded in the header file. Make this value configurable so it may be used programmatically at build time.