Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change std::is_pod to std::is_trivially_destructible in flatbuffer_conversions.h #337

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Change std::is_pod to std::is_trivially_destructible in flatbuffer_conversions.h #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change std::is_pod to std::is_trivially_destructible in flatbuffer_co… 
…nversions.h

PiperOrigin-RevId: 708383889
  • Loading branch information
@ai-edge-bot @copybara-github
ai-edge-bot authored and copybara-github committed Dec 20, 2024
commit 0481722e4d9415a2270684e432f37f239931362e
5 changes: 2 additions & 3 deletions tflite/core/api/flatbuffer_conversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,8 @@ class BuiltinDataAllocator {
// deallocation.
template <typename T>
T* AllocatePOD() {
// TODO(b/154346074): Change this to is_trivially_destructible when all
// platform targets support that properly.
static_assert(std::is_pod<T>::value, "Builtin data structure must be POD.");
static_assert(std::is_trivially_destructible<T>::value,
"Builtin data structure must be POD.");
void* allocated_memory = this->Allocate(sizeof(T), alignof(T));
return new (allocated_memory) T();
}
Expand Down