Fix warnings and version tag #569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel hides git information, so the build version was being set to the empty string.
Databean
requested review from
jemoreira,
rmuthiah,
jmacnak and
adelva1984
as code owners
jemoreira
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no warnings with
bazel build '...'inbase/cvdafter this PR.Will make comparable changes to AOSP later.
Within
base/cvd, warnings are hidden outside ofallocdandcuttlefish.The
@VCS_TAGlogic wasn't working in bazel, because bazel hides the git repository and it was producing an empty string.