Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update standard to C++17 per C++ build support #1875

Merged
merged 5 commits into from
Nov 13, 2024
Merged

update standard to C++17 per C++ build support #1875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
944d4ac
update standard to C++17 per C++ build support
dmah42 Nov 3, 2024
bb7f9ad
disable deadcode checks from clang-tidy
dmah42 Nov 3, 2024
7339256
fix redundant definition of constexpr
dmah42 Nov 3, 2024
ada6cb0
Merge branch 'main' into c++17
dmah42 Nov 7, 2024
035dff1
Merge branch 'main' into c++17
dmah42 Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/clang-tidy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ jobs:
- name: run
shell: bash
working-directory: ${{ runner.workspace }}/_build
run: run-clang-tidy
run: run-clang-tidy -checks=*,-clang-analyzer-deadcode*
2 changes: 1 addition & 1 deletion BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ licenses(["notice"])
COPTS = [
"-pedantic",
"-pedantic-errors",
"-std=c++14",
"-std=c++17",
"-Wall",
"-Wconversion",
"-Wextra",
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ if (BENCHMARK_BUILD_32_BITS)
add_required_cxx_compiler_flag(-m32)
endif()

set(BENCHMARK_CXX_STANDARD 14)
set(BENCHMARK_CXX_STANDARD 17)

set(CMAKE_CXX_STANDARD ${BENCHMARK_CXX_STANDARD})
set(CMAKE_CXX_STANDARD_REQUIRED YES)
Expand Down
2 changes: 0 additions & 2 deletions src/perf_counters.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
namespace benchmark {
namespace internal {

constexpr size_t PerfCounterValues::kMaxCounters;

#if defined HAVE_LIBPFM

size_t PerfCounterValues::Read(const std::vector<int>& leaders) {
Expand Down
2 changes: 1 addition & 1 deletion test/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ platform(
TEST_COPTS = [
"-pedantic",
"-pedantic-errors",
"-std=c++14",
"-std=c++17",
"-Wall",
"-Wconversion",
"-Wextra",
Expand Down