Add deprecation warning to all nnx.State methods
#4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
IvyZX
force-pushed
the
state-dep-warn
branch
from
f4c5c01 to
51e89c7
Compare
|
Stealing a lot of usage fixes from #4418 to patch here |
cgarciae
approved these changes
Feb 21, 2025
IvyZX
force-pushed
the
state-dep-warn
branch
from
51e89c7 to
3eabf5f
Compare
IvyZX
force-pushed
the
state-dep-warn
branch
from
3eabf5f to
ed73ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to clean up
nnx.Stateand use built-in Python dict, as proposed by #4418.In concern of active users, set a deprecation warning and let it fire for 3 months before we actually deprecate it.