Fixes #1925 non-str dict keys not suppoted in module state #4563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #2007, the issue of having a dict with non-string keys as linen module parameters was fixed but the related issue of having non-string keys as part of the state dict was not. Specifically, these cases did not work:
this is because serialization for non-int keys was fixes for
dict
but not forFrozenDict
. This uses the code fromdict
to add the same behaviour toFrozenDict
.What does this PR do?
Fixes #1925
Checklist
discussion .
documentation guidelines.