Fix incorrect usage of is_checkpoint_finalized in Checkpointer. The bug was reported when restoring a checkpoint on GCS, the checkpoint was always thought to be "not finalized".
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_492206447
branch
2 times, most recently
from
a394dbf to
47aa9ca
Compare
copybara-service
bot
changed the title
is_checkpoint_finalized in Checkpointer. The bug was reported when restoring a checkpoint on GCS, the checkpoint was always thought to be "not finalized". The issue technically affected non-GCS too, but because of the difference in the usage of a commit_success file to indicate finalization, the issue was never surfaced.is_checkpoint_finalized in Checkpointer. The bug was reported when restoring a checkpoint on GCS, the checkpoint was always thought to be "not finalized".
… bug was reported when restoring a checkpoint on GCS, the checkpoint was always thought to be "not finalized". PiperOrigin-RevId: 492206447
copybara-service
bot
force-pushed
the
test_492206447
branch
from
47aa9ca to
995b0c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect usage of
is_checkpoint_finalizedin Checkpointer. The bug was reported when restoring a checkpoint on GCS, the checkpoint was always thought to be "not finalized".