Add methodOptions to HasMethodImpl to provide custom method options.
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next up: encode the MethodOptions as a string and decode it lazily
jinwoo
reviewed
Aug 30, 2019
|
Fixed; PTAL. It turns out the test (which relied on GHC's overlapping pattern matching) wasn't catching errors correctly: It was worse on newer GHC, but even on older ones it missed a misuse of I fixed it by just calling |
jinwoo
approved these changes
Aug 30, 2019
judah
added a commit
that referenced
this pull request
Oct 15, 2019
We're not using it currently. Also, the existing approach doesn't work well with our internal Blaze rules. If we still want this long-term, we can revisit it after fixing #334.
judah
added a commit
that referenced
this pull request
Oct 15, 2019
We're not using it currently. Also, the existing approach doesn't work well with our internal Blaze rules. If we still want this long-term, we can revisit it after fixing #334.
judah
added a commit
that referenced
this pull request
Oct 15, 2019
We're not using it currently. Also, the existing approach doesn't work well with our internal Blaze rules. If we still want this long-term, we can revisit it after fixing #334.
judah
added a commit
that referenced
this pull request
Oct 16, 2019
We're not using it currently. Also, the existing approach doesn't work well with our internal Blaze rules. If we still want this long-term, we can revisit it after fixing #334.
avdv
pushed a commit
to avdv/proto-lens
that referenced
this pull request
Aug 9, 2023
…ns. (google#331) We provide the whole proto message, rather than pulling off individual fields. The set of fields may change for different builds of proto-lens (or based on extensions, though we can't see those directly due to google#27). Internally, we save the proto message in the source file as an encoded string, and decode it into a Haskell type lazily.
avdv
pushed a commit
to avdv/proto-lens
that referenced
this pull request
Aug 9, 2023
We're not using it currently. Also, the existing approach doesn't work well with our internal Blaze rules. If we still want this long-term, we can revisit it after fixing google#334.
ylecornec
pushed a commit
to ylecornec/proto-lens
that referenced
this pull request
Feb 19, 2024
…ns. (google#331) We provide the whole proto message, rather than pulling off individual fields. The set of fields may change for different builds of proto-lens (or based on extensions, though we can't see those directly due to google#27). Internally, we save the proto message in the source file as an encoded string, and decode it into a Haskell type lazily.
ylecornec
pushed a commit
to ylecornec/proto-lens
that referenced
this pull request
Feb 19, 2024
We're not using it currently. Also, the existing approach doesn't work well with our internal Blaze rules. If we still want this long-term, we can revisit it after fixing google#334.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We provide the whole proto message, rather than pulling off individual fields. The set of fields may change for different builds of proto-lens (or based on extensions, though we can't see those directly due to #27).
Internally, we save the proto message in the source file as an encoded string, and decode it into a Haskell type lazily.