-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove upper case constants #92
Remove upper case constants #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,3 +1,7 @@ | |||
## 0.7.2+1 | |||
|
|||
- Updated SDK version to 2.0.0-dev.17.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add:
- Switched to Dart 2 constant names
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an invisible change, so I don't see that as giving the reader of the changelog any useful information.
A developer can see it in the commit message instead.
@@ -1,10 +1,10 @@ | |||
name: protobuf | |||
version: 0.7.2 | |||
version: 0.7.2+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.7.3. I've never really understood the +NNN silliness. They're for publishing different builds of the same version, but this is a new version. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way we have traditionally handled versions below 1.0.0 in the Dart project is to treat it as a full three-digit semantic version system shifted down by one, so a patch increment over 0.7.2 is 0.7.2+1.
It's not official semantic versioning, just Dart habit. I have no problem going to 0.7.3 or 0.8.0 if you want that instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're putting far too much thought into the version numbers. :)
I'll take this as is, and update the Travis config to disable running on stable.
Travis is unhappy. We'll need to disable running on stable, and move the dartfmt task to dev. |
Labels the release -dev
No description provided.