-
Notifications
You must be signed in to change notification settings - Fork 359
Set SYSFS_PORT_SPLIT_RE #45
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I've changed the git commit author address so that it matches a CLA I've already signed |
Test: Use path returned by adb devices -l (namely 1-13.3.3), and ensure it has been parsed properly
Finally getting back to these older PRs... Why did you remove the |
Well, considering that PortPathMatcher splits and does the str to int conversion, it is a bit pointless to do it in the parameter parsing. Another way to refactor this, is to change PortPathAction to take all the possible separators using the regexp, hence returning a list of ints, and delete the code from PortPathMatcher which splits strings. |
This is still an issue... flake8 testing of https://github.com/google/python-adb on Python 3.6.3 $ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
|
Test: Use path returned by adb devices -l (namely 1-13.3.3), and ensure
it has been parsed properly