Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[font overview] Vastly improve preset glyphset selection #1967

Merged
merged 38 commits into from
Jan 21, 2025
Merged

[font overview] Vastly improve preset glyphset selection #1967

merged 38 commits into from
Jan 21, 2025

Conversation

justvanrossum
Copy link
Collaborator

@justvanrossum justvanrossum commented Jan 21, 2025 •
edited
Loading

  • Improve preset glyphset selection
  • Implement TSV/CSV parsing
  • Add fields to specify which columns to use
  • Moved preset data to JSON data file
  • Added Adobe Latin / Cyrillic / Greek glyphsets
  • Added Black Foundry's glyphsets
  • Add error reporting for glyphset fetch and parse errors
  • Add loading indicator
  • Load glyphsets in parallel

Part of #1886
This fixes #1968

@justvanrossum
Fix pointer for popup menu
4b00501
@justvanrossum
Add friendly http error strings
ccaff3a
@justvanrossum
Improve fetch error handling
a4ec4ae
@justvanrossum
Beginnings of new/better preset glyphset dialog
96e8212
@justvanrossum
Add 'suggest' link to new dialog; remove presets popup from edit dialog
5922765
@justvanrossum
Plug in add custom glyph set
12811f0
@justvanrossum
Rename function, refine dialog title
4face76
@justvanrossum
Move glyphset collection data to json file; fiddle with names
f95f77c
@justvanrossum
give fetchJSON options arg, improve default caching behavior
42e1591
@justvanrossum
The button is not only for 'add' anymore, so 'Save' seems more approp…
9611770 
…riate
@justvanrossum
Remove no-cache default: no need for it after all
8995228
@justvanrossum
Rename module
a02f203
@justvanrossum
Invalidate cache for edited glyph sets; prepare for more find-grained…
c70650b 
… data format options
@justvanrossum
Allow collections to have global dataOptions
c070b5b
@justvanrossum
Beginnings of tsv/csv parsing
b4bb43e
@justvanrossum
Add Black Foundry collection; add collection-level data options
c07c5c4
@justvanrossum
Allow code point OR glyph name to be missing
acf0db7
@justvanrossum
Add some Adobe char sets
28861cb
@justvanrossum
Log error on parse error
43bf3e2
@justvanrossum
Refactor parsing per data format; guess row separator
44af842
@justvanrossum
Prefix Black Foundry sets with BF
8e2dd24
@justvanrossum
Add glyphset collection scrape script
209a8cc
@justvanrossum
Refactor so we can load glyphsets in parallel, add loading indicator
8466f63
@justvanrossum
Ensure the glyphset section is open when adding/editing
a86bec3
@justvanrossum
Actually, this is only needed when we add
d287504
@justvanrossum
Fix label alignment
0a3e117
@justvanrossum
Sort collections by name
1c21b98
@justvanrossum
Remember last selected glyphset collection
b89b859
@justvanrossum
Remove unused css class, improve 'suggest' label
8479dce
@justvanrossum
Improve button title
a9870f2
@justvanrossum justvanrossum merged commit b01efbf into main Jan 21, 2025
5 checks passed
@justvanrossum justvanrossum deleted the add-glyphset-dialog branch January 21, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[font overview / glyph sets] Finish glyphset parser (read tsv/csv, text + glyph names)
1 participant
@justvanrossum