Fix issue #7 #11
Closed
Fix issue #7 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue is "panic: runtime error: cgo argument has Go pointer to Go pointer" From golang guidline, since go 1.6, "Go code may not store a Go pointer in C memory." This fix use stream id as custom data passed into c, and uses a map to find the stream by id in the callback. Thus no more Go pointer in C memory.
|
Just gave this a test in a project I'm upgrading to go1.6. Works as advertised, many thanks. |
|
@gordonklaus Can you please merge this? |
|
This is fixed in 21c960f |
|
@gordonklaus Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the finalized proposed fix for issue #7.