fix: ensure modal are resized with keyboard #2115
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On android the modal doesn't follow the keyboard size.
This PR should fix: #1934
This fix may also fix animation lags when keyboard is opening.
Changes done
To test the changes with the sample I had to
-
is not accepted)To test the build I also add
biome
package in devDependency. It is necessary to runyarn lint
locally.If it is tool much changes for 1 PR, I can split it into multiple PR.
Sample video
Here is a video of the behavior before the fix:
When keyboard size change the bottom sheet do not move
bottomSheet.mp4
and after:
When keyboard size change the bottom sheet now move
bottomSheet2.mp4