Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure modal are resized with keyboard #2115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

freeboub
Copy link

Motivation

On android the modal doesn't follow the keyboard size.
This PR should fix: #1934
This fix may also fix animation lags when keyboard is opening.

Changes done

  • Integrate react-native-keyboard-controller to catch correctly

To test the changes with the sample I had to

  • eject from expo-go
  • rename adaptive-icon.png to adaptive_icon.png (- is not accepted)

To test the build I also add biome package in devDependency. It is necessary to run yarn lint locally.

If it is tool much changes for 1 PR, I can split it into multiple PR.

Sample video

Here is a video of the behavior before the fix:
When keyboard size change the bottom sheet do not move

bottomSheet.mp4

and after:

When keyboard size change the bottom sheet now move

bottomSheet2.mp4

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4][v5] [Android] | TextInput at the bottom of a scroll view falls behind keyboard
1 participant