Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Review language tags and add mul #472

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

RVA2869
Copy link
Collaborator

@RVA2869 RVA2869 commented Dec 24, 2024

Description

I added mul to all queries except topics.rq.
I also fixed some errors. For example German in East Timor and added some more official languages.

Side note

I'm not sure what to do with this:

SERVICE wikibase:label {
    # this might need to be updated when new countries are added
    bd:serviceParam wikibase:language "en,sv,de,mul" .

Are all languages supposed to be included or?

Fixes #469

PR Details

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Code refactor

Checklist

Please ensure the following before submitting the PR:

  • I have tested the changes locally, and they work as expected.
  • The code follows the project's coding standards and conventions.
  • Any query changes have been verified and are working correctly.
  • I have updated relevant documentation (if needed).
  • I have added unit tests or performed manual testing where necessary.

Screenshots (applicable to user interface changes)

@RVA2869 RVA2869 changed the title 📝 Review language tags and add 'mul' 📝 Review language tags and add mul Dec 24, 2024
@RVA2869 RVA2869 requested review from Ainali and Abbe98 December 24, 2024 12:38
@Ainali
Copy link
Member

Ainali commented Dec 24, 2024

Oh, German in East Timor was not an accident, it was there on purpose as it happens that it is a German on German Wikipedia that does most of the edits.

@RVA2869
Copy link
Collaborator Author

RVA2869 commented Dec 25, 2024

Oh, German in East Timor was not an accident, it was there on purpose as it happens that it is a German on German Wikipedia that does most of the edits.

I see,... but that's a bit strange, isn't it? If the 3 previous languages fail (worst case senario), then German is visible in a non-German speaking country.

@Ainali
Copy link
Member

Ainali commented Dec 25, 2024

I see,... but that's a bit strange, isn't it? If the 3 previous languages fail (worst case senario), then German is visible in a non-German speaking country.

Well, it is a bit obscure, but more human-readable than a Qid which would otherwise be the case.

@Abbe98
Copy link
Member

Abbe98 commented Jan 3, 2025

Are all languages supposed to be included or?

I think this was indeed my intention once upon a time to ensure fallbacks for all countries. However, that's not a very good idea consider that languages can overlap across countries weird ways. I'm not entirely sure what to do about it.

@Abbe98
Copy link
Member

Abbe98 commented Jan 3, 2025

This is a great improvement @RVA2869, thank you so much!

@Abbe98 Abbe98 merged commit 7dffae2 into govdirectory:main Jan 3, 2025
2 checks passed
@RVA2869 RVA2869 deleted the review-language-tags-and-add-mul branch January 3, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mul as fallback langauage in all queries
3 participants