Implement get_devices + add more tests

mygpoclient/api.py

@@ -75,6 +75,10 @@ def __init__(self, device_id, caption, type, subscriptions):
         self.type = type
         self.subscriptions = int(subscriptions)
 
+    @classmethod
+    def from_dictionary(cls, d):
+        return cls(d['id'], d['caption'], d['type'], d['subscriptions'])
+
 class EpisodeAction(object):
     """This class encapsulates an episode action
 
@@ -208,7 +212,14 @@ def get_devices(self):
         list to the user or to determine device IDs to pull
         the subscription list from.
         """
-        return []
+        uri = self._locator.device_list_uri()
+        dicts = self._client.GET(uri)
+        if dicts is None:
+            raise InvalidResponse('No response received')
 
+        try:
+            return [PodcastDevice.from_dictionary(d) for d in dicts]
+        except KeyError:
+            raise InvalidResponse('Missing keys in device list response')
 
 

mygpoclient/api_test.py

@@ -242,6 +242,23 @@ def test_updateDeviceSettings_returnsTrue(self):
         self.assertEquals(result, True)
         self.assert_http_request_count(1)
 
+    def test_getDevices_raisesInvalidResponse_onEmptyResponse(self):
+        self.set_http_response_value('')
+        self.assertRaises(api.InvalidResponse, self.client.get_devices)
+
+    def test_getDevices_raisesInvalidResponse_onMissingKeys(self):
+        self.set_http_response_value("""
+        [
+            {"id": "gpodder.on.my.phone",
+             "type": "mobile",
+             "subscriptions": 42},
+            {"id": "95dce59cf340123fa",
+             "caption": "The Lappy",
+             "subscriptions": 4711}
+        ]
+        """)
+        self.assertRaises(api.InvalidResponse, self.client.get_devices)
+
     def test_getDevices_returnsDeviceList(self):
         self.set_http_response_value("""
         [
@@ -252,7 +269,7 @@ def test_getDevices_returnsDeviceList(self):
             {"id": "95dce59cf340123fa",
              "caption": "The Lappy",
              "type": "laptop",
-             "subscriptions": 4711},
+             "subscriptions": 4711}
         ]
         """)
         devices = self.client.get_devices()