Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update channel scanning #171

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

nikodemas
Copy link
Member

Hi @amotl,

I am making a new PR on the same topic of #82.

Let me know if you have any advice/comments

@nikodemas nikodemas force-pushed the update_channel_scanning branch from 86cf38f to 302747c Compare February 4, 2025 11:17
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (f310bb3) to head (302747c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
grafana_wtf/core.py 6.25% 15 Missing ⚠️
grafana_wtf/commands.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   86.23%   85.01%   -1.22%     
==========================================
  Files           9        9              
  Lines        1104     1121      +17     
==========================================
+ Hits          952      953       +1     
- Misses        152      168      +16     
Flag Coverage Δ
unittests 85.01% <5.55%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a stack. 💯

@amotl amotl merged commit 9fbfe72 into grafana-toolbox:main Feb 4, 2025
15 of 17 checks passed
@amotl
Copy link
Contributor

amotl commented Feb 4, 2025

We just released grafana-wtf 0.22.0, including your improvements. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants