-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otelcol/connector/servicegraph): add virtual_node_peer_attributes
setting to the component
#879
Draft
hainenber
wants to merge
8
commits into
grafana:main
Choose a base branch
from
hainenber:add-virtual-node-peer-attribute-setting-to-otelcol-connector-servicegraph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−43
Draft
feat(otelcol/connector/servicegraph): add virtual_node_peer_attributes
setting to the component
#879
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
67c4780
feat(otelcol/connector/servicegraph): add `virtual_node_peer_attribut…
hainenber 9da20cc
Update CHANGELOG.md
hainenber 5f04bc6
doc: add note regarding servicegraph's `virtual_node_peer_attributes`
hainenber 811bca0
Merge branch 'main' into add-virtual-node-peer-attribute-setting-to-o…
hainenber 9bad68b
Apply suggestions from code review
hainenber 9008da4
Update otelcol.connector.servicegraph.md
hainenber 03e4b8a
doc: add Paulin's suggested note
hainenber 14e3f21
Merge branch 'main' into add-virtual-node-peer-attribute-setting-to-o…
hainenber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: add Paulin's suggested note
Signed-off-by: hainenber <[email protected]>
- Loading branch information
commit 03e4b8aa290dee8ebcd1f77bb62727b7aba384a6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -108,6 +108,17 @@ Additional labels can be included using the `dimensions` configuration option: | |||||
|
||||||
When `metrics_flush_interval` is set to `0s`, metrics will be flushed on every received batch of traces. | ||||||
|
||||||
`virtual_node_peer_attributes` is useful when an OTel-instrumented client sends a request to a service which is not OTel-instrumented. | ||||||
Normally, `otelcol.connector.servicegraph` wouldn't be able to pair the client span with a service span, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
because no service span will be received if the service is not OTel-instrumented. | ||||||
When an edge expires, `otelcol.connector.servicegraph` checks if it has peer attributes listed in `virtual_node_peer_attributes`. | ||||||
If an attribute is found, the metrics are then aggregated with a virtual node. | ||||||
|
||||||
If no client span is found and `virtual_node_peer_attributes` is not an empty list, | ||||||
then the service span will be paired with a virtual node called `client="user"`. | ||||||
This can be useful when a client which is not OTel-instrumented (like a web browser) sends a request to an OTel-instrumented service. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
Without a virtual node, normally the client span will be missing, and the server span will expire without being paired. | ||||||
|
||||||
Attributes configured in the `virtual_node_peer_attributes` argument are ordered by priority. An empty list disables the creation of a virtual node. | ||||||
|
||||||
[Span Kind]: https://opentelemetry.io/docs/concepts/signals/traces/#span-kind | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.