Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sqlite builds with DQS=off #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

knz
Copy link

@knz knz commented Apr 3, 2024

If sqlite3 is built with double-quoted string literals disabled (which is recommended, see https://www.sqlite.org/compile.html#dqs), diskcache starts failing with the following crypting error:

no such column: "size"

This is because the syntax WHERE key = "size" in standard SQL refers to a column named "size", not a string literal. Parsing this as a string literal is a conditional sqlite extension.

This patch makes the code more robust by avoiding this optional sqlite feature.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
knz Raphael 'kena' Poss
If sqlite3 is built with double-quoted string literals disabled (which
is recommended, see https://www.sqlite.org/compile.html#dqs),
diskcache starts failing with the following crypting error:

```
no such column: "size"
```

This is because the syntax `WHERE key = "size"` in standard SQL refers
to a column named "size", not a string literal. Parsing this as a
string literal is a conditional sqlite extension.

This patch makes the code more robust by avoiding this optional sqlite
feature.
@knz
Copy link
Author

knz commented Apr 17, 2024

cc @grantjenks

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request May 22, 2024
@atom-andrew
Copy link

sqlite 3.49 (at least 3.49.1 released on conda forge) appears to have (possibly inadvertently) set DQS=off, so this failure has reappeared. I believe sqlite had backed away from changing this setting temporarily and I don't see the change explicitly announced in the changelog, which leads me to think this was inadvertent. Still, it would be nice to have this package be unaffeted.

@JulianEberius
Copy link

We were also bitten by this change in Conda. Agree it would be cool if diskcache would be compatible with dqs=off, since this is advocated by SQLite as the recommended option (see https://www.sqlite.org/quirks.html).

Anything we can do to help get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants