Skip to content

Commit

Permalink
RPKI: Fix unnecessary reconnection on reconfiguration
Browse files Browse the repository at this point in the history
Compare the new timing parameters with the old configuration, not with
the temporary state of the current connection.

The timing values in struct rpki_cache is updated by a version 1 End Of
Data PDU, unless this behavior is suppressed by the configuration
explicitly by the "keep" keyword. Consequently, every reconfiguration
of BIRD triggers a reconnection even if it is not necessary.
  • Loading branch information
rhenium authored and Ondrej Zajicek (work) committed Jun 3, 2020
1 parent fae5448 commit 19f8f17
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion proto/rpki/rpki.c
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,7 @@ rpki_reconfigure_cache(struct rpki_proto *p UNUSED, struct rpki_cache *cache, st
#endif

#define TEST_INTERVAL(name, Name) \
if (cache->name##_interval != new->name##_interval || \
if (old->name##_interval != new->name##_interval || \
old->keep_##name##_interval != new->keep_##name##_interval) \
{ \
cache->name##_interval = new->name##_interval; \
Expand Down

0 comments on commit 19f8f17

Please sign in to comment.