Merge pull request video-dev#2431 from Yuvalke/fix_issue_2400

fix video-dev#2400 issue - cues doesn't show up on browsers which addCue doesn't throw error with invalid structure
gregorykim · Dec 12, 2019 · 263e94b · 263e94b
2 parents ceed27e + 23aeab1
commit 263e94b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/controller/timeline-controller.ts b/src/controller/timeline-controller.ts
@@ -289,7 +289,11 @@ class TimelineController extends EventHandler {
         if (!currentTrack.cues.getCueById(cue.id)) {
           try {
             currentTrack.addCue(cue);
+            if (!currentTrack.cues.getCueById(cue.id)) {
+              throw new Error(`addCue is failed for: ${cue}`);
+            }
           } catch (err) {
+            logger.debug(`Failed occurred on adding cues: ${err}`);
             const textTrackCue = new (window as any).TextTrackCue(cue.startTime, cue.endTime, cue.text);
             textTrackCue.id = cue.id;
             currentTrack.addCue(textTrackCue);