Skip to content

Commit

Permalink
Do not set default value for any_errors_fatal in Base
Browse files Browse the repository at this point in the history
Setting default values for FieldAttribute values created in the Base class
prevents the _get_parent_attribute() code from working correctly, as the value
is always non-None.

Related to ansible#22924
  • Loading branch information
jimi-c committed Jun 16, 2017
1 parent 3eea649 commit c5b8196
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/ansible/playbook/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class Base(with_metaclass(BaseMeta, object)):
_run_once = FieldAttribute(isa='bool')
_ignore_errors = FieldAttribute(isa='bool')
_check_mode = FieldAttribute(isa='bool')
_any_errors_fatal = FieldAttribute(isa='bool', default=False, always_post_validate=True)
_any_errors_fatal = FieldAttribute(isa='bool', always_post_validate=True)

# param names which have been deprecated/removed
DEPRECATED_ATTRIBUTES = [
Expand Down

0 comments on commit c5b8196

Please sign in to comment.