Skip to content

Commit

Permalink
cmd/compile: early typecheck top level OAS2 nodes
Browse files Browse the repository at this point in the history
Fixes golang#10977.

Change-Id: I706c953c16daad48595c7fae2d82124614dfc3ad
Reviewed-on: https://go-review.googlesource.com/10780
Reviewed-by: David Chase <[email protected]>
Run-TryBot: Josh Bleecher Snyder <[email protected]>
  • Loading branch information
josharian committed Jun 9, 2015
1 parent e597e63 commit 494ff18
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/cmd/compile/internal/gc/lex.go
Original file line number Diff line number Diff line change
Expand Up @@ -370,15 +370,15 @@ func Main() {
defercheckwidth()

for l := xtop; l != nil; l = l.Next {
if l.N.Op != ODCL && l.N.Op != OAS {
if l.N.Op != ODCL && l.N.Op != OAS && l.N.Op != OAS2 {
typecheck(&l.N, Etop)
}
}

// Phase 2: Variable assignments.
// To check interface assignments, depends on phase 1.
for l := xtop; l != nil; l = l.Next {
if l.N.Op == ODCL || l.N.Op == OAS {
if l.N.Op == ODCL || l.N.Op == OAS || l.N.Op == OAS2 {
typecheck(&l.N, Etop)
}
}
Expand Down
20 changes: 20 additions & 0 deletions test/fixedbugs/issue10977.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// compile

// Copyright 2015 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package p

type T struct{}

var (
t = T{}
u = t.New()
)

func x(T) (int, int) { return 0, 0 }

var _, _ = x(u)

func (T) New() T { return T{} }

0 comments on commit 494ff18

Please sign in to comment.