Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve whitespace in Markdown code spans/blocks #1288

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Preserve whitespace in Markdown code spans/blocks #1288

merged 1 commit into from
Nov 1, 2024

Conversation

georgegevoian
Copy link
Contributor

Context

Whitespace was not preserved in Markdown code spans and blocks, breaking indentation and other formatting.

Proposed solution

Update styles for code spans and blocks to preserve whitespace.

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

Tested manually.

berhalak
berhalak approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@georgegevoian georgegevoian merged commit 70499d2 into main Nov 1, 2024
11 checks passed
@georgegevoian georgegevoian deleted the md-cell-code-whitespace-bug branch November 1, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berhalak berhalak berhalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgegevoian @berhalak