netdev-dpdk: Fix crash in QoS.

qos_conf can be NULL. This can be easily reproduced by setting egress QoS on a port: ``` ovs-vsctl set port dpdk2 qos=@newqos -- --id=@newqos create qos type=egress-policer other-config:cir=46000000 other-config:cbs=2048 ``` Reported-by: Ian Stokes <[email protected]> Fixes: 78bd47c ("netdev-dpdk: Use RCU for egress QoS.") Signed-off-by: Daniele Di Proietto <[email protected]> Tested-by: Ian Stokes <[email protected]> Acked-by: Ian Stokes <[email protected]>
grizax · Nov 15, 2016 · 44975bb · 44975bb
1 parent 63906f1
commit 44975bb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
@@ -2803,7 +2803,7 @@ netdev_dpdk_set_qos(struct netdev *netdev, const char *type,
         if (type && type[0]) {
             error = EOPNOTSUPP;
         }
-    } else if (qos_conf->ops == new_ops
+    } else if (qos_conf && qos_conf->ops == new_ops
                && qos_conf->ops->qos_is_equal(qos_conf, details)) {
         new_qos_conf = qos_conf;
     } else {