Minor fixes from #7 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the template fix. As for
Also, please rebase this PR on the rewritten master branch. |
A missing </div> was at times causing the footer to go out of place and cover the form contents.
vladimir-mencl-eresearch
force-pushed
the
minor-fixes-feb16
branch
from
32f977d to
6bd36ac
Compare
As per discussion in grnet#10: * Make PyYAML import floating in 3.x (without pinning to 3.0.10) * Move Mako import to new file requirements-optional.txt * Update docs/installation/requirements.md to refer to requirements-optional.txt
|
Hi Zenon, Most packages are listed as pinned to exact versions - but I've updated the PR as requested and rebased - can you please merge? Cheers, |
zmousm
added a commit
that referenced
this pull request
Feb 22, 2016
Minor fixes from #7 - missing tag in servers_edit template - missing PyYAML dep in requirements.txt - Mako as an optional requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Zenon,
I have cherry-picked the two commits from #7 that are not related to the InstServer M2M change - please let me know if you are happy to merge these two minor fixes.
Cheers,
Vlad