Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sc-5375] - add gorelease and workflows #16

Merged
merged 2 commits into from
Nov 7, 2022
Merged

[sc-5375] - add gorelease and workflows #16

merged 2 commits into from
Nov 7, 2022

Conversation

maxlevinps
Copy link
Collaborator

What this PR does / why we need it:
In this PR we've added github workflows for:

  • pr: for each PR we will build the project and fail if it won't, in the future we will want to run tests here as well.
  • release: on each new version tag the release workflow will run and build murre artifacts

Which issue(s) this PR fixes:
#9

Special notes for your reviewer:

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #5374: add gorelease.

@maxlevinps maxlevinps requested a review from noamApps October 25, 2022 14:46
@noamApps noamApps requested a review from steb-veksler October 25, 2022 15:01
steb-veksler
steb-veksler suggested changes Oct 25, 2022
View reviewed changes
Copy link

@steb-veksler steb-veksler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add CHANGELOG.MD

@maxlevinps maxlevinps merged commit 958fbe5 into main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steb-veksler steb-veksler steb-veksler approved these changes

@noamApps noamApps Awaiting requested review from noamApps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxlevinps @steb-veksler