Skip to content

Commit

Permalink
configs: Make USE_TINY_PRINTF depend on SPL||TPL and be default
Browse files Browse the repository at this point in the history
The USE_TINY_PRINTF symbol only changes things within SPL and TPL
builds, so make it depend on that support.  Next, make it default as
within these cases we should rarely have need of more advanced print
formats outside of the debug context.

To do this, in a few cases we need to correct our Kconfig dependencies
as we had cases of non-SPL targets select'ing this symbol.  Finally, in
the case of a few boards we really do need the full printf
functionality.

Signed-off-by: Tom Rini <[email protected]>
  • Loading branch information
trini committed Jul 13, 2019
1 parent 28115e7 commit 2a51e16
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion arch/arm/mach-omap2/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ config OMAP34XX
select ARM_ERRATA_454179
select ARM_ERRATA_621766
select ARM_ERRATA_725233
select USE_TINY_PRINTF
select USE_TINY_PRINTF if SPL
imply NAND_OMAP_GPMC
imply SPL_FS_EXT4
imply SPL_FS_FAT
Expand Down
1 change: 0 additions & 1 deletion arch/arm/mach-rmobile/Kconfig.32
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ config TARGET_BLANCHE
bool "Blanche board"
select DM
select DM_SERIAL
select USE_TINY_PRINTF
imply CMD_DM

config TARGET_GOSE
Expand Down
1 change: 1 addition & 0 deletions configs/ls1043ardb_nand_SECURE_BOOT_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_XHCI_HCD=y
CONFIG_USB_XHCI_DWC3=y
# CONFIG_USE_TINY_PRINTF is not set
CONFIG_RSA=y
CONFIG_SPL_RSA=y
CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
1 change: 1 addition & 0 deletions configs/ls1043ardb_nand_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,5 @@ CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_XHCI_HCD=y
CONFIG_USB_XHCI_DWC3=y
# CONFIG_USE_TINY_PRINTF is not set
CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
1 change: 1 addition & 0 deletions configs/ls1043ardb_sdcard_SECURE_BOOT_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_XHCI_HCD=y
CONFIG_USB_XHCI_DWC3=y
# CONFIG_USE_TINY_PRINTF is not set
CONFIG_RSA=y
CONFIG_SPL_RSA=y
CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
1 change: 1 addition & 0 deletions configs/ls1043ardb_sdcard_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,5 @@ CONFIG_USB=y
CONFIG_DM_USB=y
CONFIG_USB_XHCI_HCD=y
CONFIG_USB_XHCI_DWC3=y
# CONFIG_USE_TINY_PRINTF is not set
CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
1 change: 1 addition & 0 deletions configs/sandbox_spl_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ CONFIG_OSD=y
CONFIG_SANDBOX_OSD=y
CONFIG_FS_CBFS=y
CONFIG_FS_CRAMFS=y
# CONFIG_USE_TINY_PRINTF is not set
CONFIG_CMD_DHRYSTONE=y
CONFIG_TPM=y
CONFIG_LZ4=y
Expand Down
2 changes: 2 additions & 0 deletions lib/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ config SYS_HZ

config USE_TINY_PRINTF
bool "Enable tiny printf() version"
depends on SPL || TPL
default y
help
This option enables a tiny, stripped down printf version.
This should only be used in space limited environments,
Expand Down

0 comments on commit 2a51e16

Please sign in to comment.