Skip to content

Commit

Permalink
disk: efi: correct the allocation size for mbr header in stack
Browse files Browse the repository at this point in the history
use ALLOC_CACHE_ALIGN_BUFFER_PAD for mbr header allocation
in stack to fix alloc issue in is_gpt_valid()

this patch fix also issue for GPT partition handling
with blocksize != 512 in set_protective_mbr()

Signed-off-by: Patrick Delaunay <[email protected]>
  • Loading branch information
patrickdelaunay authored and trini committed Nov 30, 2017
1 parent aaa4ba9 commit 3cc5661
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions disk/part_efi.c
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ static int part_test_efi(struct blk_desc *dev_desc)
static int set_protective_mbr(struct blk_desc *dev_desc)
{
/* Setup the Protective MBR */
ALLOC_CACHE_ALIGN_BUFFER(legacy_mbr, p_mbr, 1);
ALLOC_CACHE_ALIGN_BUFFER_PAD(legacy_mbr, p_mbr, 1, dev_desc->blksz);
memset(p_mbr, 0, sizeof(*p_mbr));

if (p_mbr == NULL) {
Expand Down Expand Up @@ -931,7 +931,7 @@ static int is_gpt_valid(struct blk_desc *dev_desc, u64 lba,
return 0;
}

ALLOC_CACHE_ALIGN_BUFFER(legacy_mbr, mbr, dev_desc->blksz);
ALLOC_CACHE_ALIGN_BUFFER_PAD(legacy_mbr, mbr, 1, dev_desc->blksz);

/* Read MBR Header from device */
if (blk_dread(dev_desc, 0, 1, (ulong *)mbr) != 1) {
Expand Down

0 comments on commit 3cc5661

Please sign in to comment.