Skip to content

Commit

Permalink
spi: Remove obsolete spi_base_setup_slave_fdt
Browse files Browse the repository at this point in the history
0efc024 ("spi_flash: Add spi_flash_probe_fdt() to locate SPI by FDT
node") added a helper function spi_base_setup_slave_fdt to to set up a
SPI slave from a given FDT blob. The only user was the exynos SPI
driver.

But commit 73186c9 ("dm: exynos: Convert SPI to driver model") removed
the use of this function, hence rendering it obsolete.

Remove this function, as well as the CONFIG_OF_SPI option, which guarded
only this function.

Reviewed-by: Simon Glass <[email protected]>
Reviewed-by: Jagan Teki <[email protected]>
Signed-off-by: Mario Six <[email protected]>
  • Loading branch information
si-gdsys authored and openedev committed Jan 24, 2018
1 parent 547bcc3 commit c5b88f2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 35 deletions.
20 changes: 0 additions & 20 deletions drivers/spi/spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,23 +39,3 @@ void *spi_do_alloc_slave(int offset, int size, unsigned int bus,

return ptr;
}

#ifdef CONFIG_OF_SPI
struct spi_slave *spi_base_setup_slave_fdt(const void *blob, int busnum,
int node)
{
int cs, max_hz, mode = 0;

cs = fdtdec_get_int(blob, node, "reg", -1);
max_hz = fdtdec_get_int(blob, node, "spi-max-frequency", 100000);
if (fdtdec_get_bool(blob, node, "spi-cpol"))
mode |= SPI_CPOL;
if (fdtdec_get_bool(blob, node, "spi-cpha"))
mode |= SPI_CPHA;
if (fdtdec_get_bool(blob, node, "spi-cs-high"))
mode |= SPI_CS_HIGH;
if (fdtdec_get_bool(blob, node, "spi-half-duplex"))
mode |= SPI_PREAMBLE;
return spi_setup_slave(busnum, cs, max_hz, mode);
}
#endif
14 changes: 0 additions & 14 deletions include/spi.h
Original file line number Diff line number Diff line change
Expand Up @@ -330,20 +330,6 @@ static inline int spi_w8r8(struct spi_slave *slave, unsigned char byte)
*/
struct spi_slave *spi_setup_slave_fdt(const void *blob, int slave_node,
int spi_node);

/**
* spi_base_setup_slave_fdt() - helper function to set up a SPI slace
*
* This decodes SPI properties from the slave node to determine the
* chip select and SPI parameters.
*
* @blob: Device tree blob
* @busnum: Bus number to use
* @node: Device tree node for the SPI bus
*/
struct spi_slave *spi_base_setup_slave_fdt(const void *blob, int busnum,
int node);

#ifdef CONFIG_DM_SPI

/**
Expand Down
1 change: 0 additions & 1 deletion scripts/config_whitelist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1554,7 +1554,6 @@ CONFIG_NUM_PAMU
CONFIG_ODROID_REV_AIN
CONFIG_OFF_PADCONF
CONFIG_OF_
CONFIG_OF_SPI
CONFIG_OF_SPI_FLASH
CONFIG_OF_STDOUT_PATH
CONFIG_OMAP_EHCI_PHY1_RESET_GPIO
Expand Down

0 comments on commit c5b88f2

Please sign in to comment.