Skip to content

Commit

Permalink
binman: Use the Makefile for u_boot_binman_syms_size
Browse files Browse the repository at this point in the history
Remove this file from git and instead build it using the Makefile.

Signed-off-by: Simon Glass <[email protected]>
  • Loading branch information
sjg20 committed Oct 15, 2019
1 parent 1542c8b commit e9d2ee3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions tools/binman/elf_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ def BuildElfTestFiles(target_dir):
tools.Run('make', '-C', target_dir, '-f',
os.path.join(testdir, 'Makefile'), 'SRC=%s/' % testdir,
'bss_data', 'u_boot_ucode_ptr', 'u_boot_no_ucode_ptr',
'u_boot_binman_syms', 'u_boot_binman_syms.bin')
'u_boot_binman_syms', 'u_boot_binman_syms.bin',
'u_boot_binman_syms_size')


class TestElf(unittest.TestCase):
Expand Down Expand Up @@ -145,7 +146,7 @@ def testBadSymbolSize(self):
"""
entry = FakeEntry(10)
section = FakeSection()
elf_fname = os.path.join(binman_dir, 'test', 'u_boot_binman_syms_size')
elf_fname =self.ElfTestFile('u_boot_binman_syms_size')
with self.assertRaises(ValueError) as e:
syms = elf.LookupAndWriteSymbols(elf_fname, entry, section)
self.assertIn('has size 1: only 4 and 8 are supported',
Expand Down
2 changes: 1 addition & 1 deletion tools/binman/ftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ def _SetupSplElf(cls, src_fname='bss_data'):
"""
# TODO([email protected]): Drop this when all Elf files use ElfTestFile()
if src_fname in ['bss_data', 'u_boot_ucode_ptr', 'u_boot_no_ucode_ptr',
'u_boot_binman_syms']:
'u_boot_binman_syms', 'u_boot_binman_syms_size']:
fname = cls.ElfTestFile(src_fname)
else:
fname = cls.TestFile(src_fname)
Expand Down
Binary file removed tools/binman/test/u_boot_binman_syms_size
Binary file not shown.

0 comments on commit e9d2ee3

Please sign in to comment.