[Weather] Add a default of 240 minutes for the updateInterval. (openh…

…ab#4403)

* Add a default of 240 minutes for the updateInterval.

Also added an early shortcut in the validation logic.

* Fix formatting.

* Update to include a constant for the default update interval.

bundles/binding/org.openhab.binding.weather/src/main/java/org/openhab/binding/weather/internal/common/LocationConfig.java

@@ -19,12 +19,14 @@
  * @since 1.6.0
  */
 public class LocationConfig {
+    private static final int DEFAULT_UPDATE_INTERVAL = 240;
+
     private ProviderName providerName;
     private String language = "en";
     private Double latitude;
     private Double longitude;
     private String woeid;
-    private Integer updateInterval;
+    private Integer updateInterval = DEFAULT_UPDATE_INTERVAL;
     private String locationId;
     private String name;
 
@@ -145,12 +147,15 @@ public void setName(String name) {
      */
     public boolean isValid() {
         boolean valid = providerName != null && language != null && updateInterval != null && locationId != null;
+        if (!valid) {
+            return false;
+        }
+
         if (providerName == ProviderName.YAHOO) {
-            valid = valid && woeid != null;
+            return woeid != null;
         } else {
-            valid = valid && latitude != null && longitude != null;
+            return latitude != null && longitude != null;
         }
-        return valid;
     }
 
     /**