Passcodes | Auto submit form on paste or change when valid #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldlink
added
the
passwordless
coldlink
force-pushed
the
mm/auto-submit-code
branch
from
79dce06 to
edd2687
Compare
AshCorr
previously approved these changes
Feb 5, 2025
| @@ -8,6 +8,7 @@ import { remSpace } from '@guardian/source/foundations'; | |||
| interface PasscodeInputProps extends TextInputProps { | |||
| passcode?: string; | |||
| fieldErrors?: FieldError[]; | |||
| formRef?: React.RefObject<HTMLFormElement | null>; | |||
There was a problem hiding this comment.
The way it's currently being used, it's always defined, so will refactor that.
| @@ -112,6 +112,7 @@ export const PasscodeEmailSent = ({ | |||
| const [recaptchaErrorMessage, setRecaptchaErrorMessage] = useState(''); | |||
| const [recaptchaErrorContext, setRecaptchaErrorContext] = | |||
| useState<ReactNode>(null); | |||
| const formRef = createRef<HTMLFormElement>(); | |||
There was a problem hiding this comment.
Should we use useRef instead as we're using function components
as per
https://react.dev/reference/react/createRef
There was a problem hiding this comment.
Ah good spot! I'll try and refactor it!
coldlink
force-pushed
the
mm/auto-submit-code
branch
from
edd2687 to
9ed284a
Compare
AshCorr
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Currently the reader has to manually submit the code after typing it in or pasting it in.
To make it faster for the reader, this PR updates the functionality to automatically submit the code when it reaches 6 digits long or pasting it in.
We added checks to make sure that the auto-submission is disabled for specifc scenarios
It is also disabled in scenarios where
formRefisn't passed in.Speaking of which, a minor refactor had to be performed on the
MainFormto makeformRefa parameter instead. This allows us to pass in areffor theMainForm, so it can be used in other components, specifically in this scenario thePasscodeInputcomponent.Finally
PasscodeEmailSentpage was updated to create the newformRefand pass it to bothMainFormandPasscodeInputScreen.Recording.2025-02-04.at.08.52.11.mov
Screen.Recording.2025-02-04.at.09.00.35.mov
Screen.Recording.2025-02-04.at.08.59.09.mov
Screen.Recording.2025-02-04.at.09.01.25.mov
Tested