fixed incorrect looping from length + 1 to length in parse descriptor…

…, and removed unnecessary undefined check
guardian · Oct 4, 2014 · c409c9d · c409c9d
1 parent 80573aa
commit c409c9d
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/src/picturefill.js b/src/picturefill.js
@@ -263,17 +263,15 @@
 			if ( sizeDescriptor ) {
 				var splitDescriptor = sizeDescriptor.split(" ");
 
-				for (var i = splitDescriptor.length + 1; i >= 0; i--) {
-					if ( splitDescriptor[ i ] !== undefined ) {
-						var curr = splitDescriptor[ i ],
-							lastchar = curr && curr.slice( curr.length - 1 );
-
-						if ( ( lastchar === "h" || lastchar === "w" ) && !pf.sizesSupported ) {
-							resCandidate = parseFloat( ( parseInt( curr, 10 ) / widthInCssPixels ) );
-						} else if ( lastchar === "x" ) {
-							var res = curr && parseFloat( curr, 10 );
-							resCandidate = res && !isNaN( res ) ? res : 1;
-						}
+				for (var i = splitDescriptor.length - 1; i >= 0; i--) {
+					var curr = splitDescriptor[ i ],
+						lastchar = curr && curr.slice( curr.length - 1 );
+
+					if ( ( lastchar === "h" || lastchar === "w" ) && !pf.sizesSupported ) {
+						resCandidate = parseFloat( ( parseInt( curr, 10 ) / widthInCssPixels ) );
+					} else if ( lastchar === "x" ) {
+						var res = curr && parseFloat( curr, 10 );
+						resCandidate = res && !isNaN( res ) ? res : 1;
 					}
 				}
 			}