fix allocate and resize having corrupted values or OOB exceptions

guerro323 · Mar 4, 2023 · 869cfc1 · 869cfc1
1 parent f9d9769
commit 869cfc1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.idea/.idea.revghost/.idea/riderMarkupCache.xml b/.idea/.idea.revghost/.idea/riderMarkupCache.xml
diff --git a/revghost.Shared/Collections/ValueList.Private.cs b/revghost.Shared/Collections/ValueList.Private.cs
@@ -28,7 +28,7 @@ private void Allocate(int size)
                 var old = Data;
                 Data = ArrayPool<T>.Shared.Rent(size);
 
-                Array.Copy(old, Data, old.Length);
+                Array.Copy(old, Data, Math.Min(size, old.Length));
             }
             else
             {
@@ -48,6 +48,9 @@ public void Resize(int newSize)
                 return;
             }
 
+            if (newSize < length)
+                return;
+
             var target = length == 0 ? 16 : length * 2;
             if (target < newSize)
                 target = newSize;