Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatically use Deployment instead of StatefulSet #59

Merged
merged 10 commits into from
Dec 9, 2023

Conversation

PKizzle
Copy link
Contributor

@PKizzle PKizzle commented Dec 1, 2023

Closes #4

When a persistent data storage and an external database are used automatically switch to use a Deployment instead of a StatefulSet. This can be manually overridden using the deploymentKind option.

@PKizzle PKizzle changed the title Automatically use Deployment instead of StatefulSet feat: Automatically use Deployment instead of StatefulSet Dec 1, 2023
@guerzon
Copy link
Owner

guerzon commented Dec 2, 2023

Thanks or the PR @PKizzle. Could you bump the chart version also? I suggest 0.18.0. Thanks.

@guerzon guerzon self-assigned this Dec 2, 2023
charts/vaultwarden/values.yaml Outdated Show resolved Hide resolved
charts/vaultwarden/values.yaml Outdated Show resolved Hide resolved
charts/vaultwarden/templates/_pvcSpec.tpl Outdated Show resolved Hide resolved
charts/vaultwarden/templates/configmap.yaml Show resolved Hide resolved
charts/vaultwarden/templates/service.yaml Show resolved Hide resolved
charts/vaultwarden/values.yaml Outdated Show resolved Hide resolved
@guerzon
Copy link
Owner

guerzon commented Dec 6, 2023

It would be nice if in charts/vaultwarden/README.md you could also write an explanation on when a Deployment will be used vs. when a Statefulset will be used.

@guerzon
Copy link
Owner

guerzon commented Dec 9, 2023

Thanks for the changes @PKizzle and for adding the value annotations.

charts/vaultwarden/templates/pvc.yaml Outdated Show resolved Hide resolved
@guerzon guerzon merged commit ba5ff95 into guerzon:main Dec 9, 2023
1 check passed
@PKizzle PKizzle deleted the feature/automatic-switch-to-deployment branch December 15, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Use a Deployment when using external database?
2 participants