Fix a consistency issue with command line parsing of file names (use …

…FileInfo instead of string) (dotnet#2033) * Fix a consistency issue with command line parsing of file names (use FileInfo instead of string)
gugavaro · Feb 5, 2020 · 211b4b2 · 211b4b2
1 parent 693d07f
commit 211b4b2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/ReadyToRunCodegenCompilationBuilder.cs b/...src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/ReadyToRunCodegenCompilationBuilder.cs
@@ -4,7 +4,7 @@
 
 using System;
 using System.Collections.Generic;
-
+using System.IO;
 using ILCompiler.DependencyAnalysis;
 using ILCompiler.DependencyAnalysis.ReadyToRun;
 using ILCompiler.DependencyAnalysisFramework;
@@ -78,9 +78,9 @@ protected override ILProvider GetILProvider()
             return _ilProvider;
         }
 
-        public ReadyToRunCodegenCompilationBuilder UseJitPath(string jitPath)
+        public ReadyToRunCodegenCompilationBuilder UseJitPath(FileInfo jitPath)
         {
-            _jitPath = jitPath;
+            _jitPath = jitPath == null ? null : jitPath.FullName;
             return this;
         }
 

diff --git a/src/coreclr/src/tools/crossgen2/crossgen2/CommandLineOptions.cs b/src/coreclr/src/tools/crossgen2/crossgen2/CommandLineOptions.cs
@@ -26,7 +26,7 @@ public class CommandLineOptions
 
         public string TargetArch { get; set; }
         public string TargetOS { get; set; }
-        public string JitPath { get; set; }
+        public FileInfo JitPath { get; set; }
         public string SystemModule { get; set; }
         public bool WaitForDebugger { get; set; }
         public bool Tuning { get; set; }
@@ -136,7 +136,7 @@ public static Command RootCommand()
                 },
                 new Option(new[] { "--jitpath" }, "Path to JIT compiler library") 
                 { 
-                    Argument =  new Argument<string>() 
+                    Argument =  new Argument<FileInfo>() 
                 },
                 new Option(new[] { "--singlemethodtypename" }, "Single method compilation: name of the owning type") 
                 {