forked from dotnet/runtime
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[runtime] Report crash when receiving crashing signals (dotnet#2052)
The default handlers for SIGTRAP, SIGSYS on macOS and Linux crash the process, so we now have Mono report this. This change also changes the presentation of the signal name on the stacktrace report dumped on error (from e.g. "SIGSEGV" to "segv"). Co-authored-by: Alexis Christoforides <[email protected]>
- Loading branch information
1 parent
d89fc6d
commit 8c941a5
Showing
15 changed files
with
149 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| #include "config.h" | ||
| #include <signal.h> | ||
| #include <string.h> | ||
| #include "mono/utils/mono-signal-handler.h" | ||
|
|
||
| struct mono_sigpair | ||
| { | ||
| int signo; | ||
| const char* signame; | ||
| }; | ||
|
|
||
| #if !defined (HAVE_SYSSIGNAME) | ||
| static struct mono_sigpair mono_signames[] = | ||
| { | ||
| {SIGABRT, "SIGABRT"}, | ||
| #if defined (SIGKILL) | ||
| {SIGKILL, "SIGKILL"}, | ||
| #endif | ||
| #if defined (SIGTRAP) | ||
| {SIGTRAP, "SIGTRAP"}, | ||
| #endif | ||
| #if defined (SIGSYS) | ||
| {SIGSYS, "SIGSYS"}, | ||
| #endif | ||
| {SIGSEGV, "SIGSEGV"}, | ||
| #if defined (SIGQUIT) | ||
| {SIGQUIT, "SIGQUIT"}, | ||
| #endif | ||
| {SIGFPE, "SIGFPE"}, | ||
| {SIGILL, "SIGILL"}, | ||
| #if defined (SIGBUS) | ||
| {SIGBUS, "SIGBUS"} // How come this is seems not available on Android, but is used unconditionally in mini-posix.c:mono_runtime_posix_install_handlers ? | ||
| #endif | ||
| }; | ||
| #endif | ||
|
|
||
| static struct mono_sigpair *sigpair_buf; | ||
| static int sigpair_buflen; | ||
|
|
||
| void | ||
| mono_load_signames () | ||
| { | ||
| if (sigpair_buf) | ||
| return; | ||
| #if defined (HAVE_SYSSIGNAME) | ||
| sigpair_buflen = sizeof (sys_signame) / sizeof (sys_signame [0]); | ||
| sigpair_buf = (struct mono_sigpair *) g_malloc (sigpair_buflen * sizeof (struct mono_sigpair)); | ||
| struct mono_sigpair *cur = sigpair_buf; | ||
| for (int i = 0; i < sigpair_buflen; ++i) | ||
| { | ||
| cur->signo = i; | ||
| cur->signame = sys_signame [i]; | ||
| cur++; | ||
| } | ||
|
|
||
| #else | ||
| sigpair_buflen = sizeof (mono_signames) / sizeof (mono_signames [0]); | ||
| sigpair_buf = mono_signames; | ||
| #endif | ||
|
|
||
| } | ||
|
|
||
| const char * | ||
| mono_get_signame (int signo) | ||
| { | ||
| const char *result = "UNKNOWN"; | ||
| struct mono_sigpair *cur = sigpair_buf; | ||
| for (int i = 0; i < sigpair_buflen; ++i) | ||
| { | ||
| if (cur->signo == signo) | ||
| { | ||
| result = cur->signame; | ||
| break; | ||
| } | ||
| cur++; | ||
| } | ||
| return result; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.