Prevent timing NPEs on CrawlLimitEnforcer-triggered crawl end

* AbstractFrontier.java close recovery log in stop() (comes later, usu. from managerThread) rather than terminate() (earlier, may occur in other threads like progress-stats-snapshot thread)
guitarscape · Dec 5, 2009 · 7d00618 · 7d00618
1 parent 21d4bce
commit 7d00618
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/engine/src/main/java/org/archive/crawler/frontier/AbstractFrontier.java b/engine/src/main/java/org/archive/crawler/frontier/AbstractFrontier.java
@@ -170,6 +170,7 @@ public boolean isRunning() {
 
     public void stop() {
         terminate();
+        ArchiveUtils.closeQuietly(this.recover);
     }
 
 
@@ -643,8 +644,6 @@ public void unpause() {
 
     synchronized public void terminate() {
         requestState(State.FINISH);
-        // TODO: move this recover-cleanup to manager thread?
-        ArchiveUtils.closeQuietly(this.recover);
     }
 
     /**