refactor: extract handle message from WsAdapter

gujieye · Oct 17, 2018 · a6b0016 · a6b0016
1 parent 3e9bfff
commit a6b0016
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/packages/websockets/adapters/ws-adapter.ts b/packages/websockets/adapters/ws-adapter.ts
@@ -15,10 +15,10 @@ import { MessageMappingProperties } from '../gateway-metadata-explorer';
 let wsPackage: any = {};
 
 enum READY_STATE {
-    CONNECTING_STATE = 0,
-    OPEN_STATE = 1,
-    CLOSING_STATE = 2,
-    CLOSED_STATE = 3,
+  CONNECTING_STATE = 0,
+  OPEN_STATE = 1,
+  CLOSING_STATE = 2,
+  CLOSED_STATE = 3,
 }
 
 export class WsAdapter implements WebSocketAdapter {
@@ -79,11 +79,13 @@ export class WsAdapter implements WebSocketAdapter {
       ),
       takeUntil(close$),
     );
-    source$.subscribe(response => {
-      if (client.readyState === READY_STATE.OPEN_STATE) {
-          client.send(JSON.stringify(response));
+    const handleMessage = response => {
+      if (client.readyState !== READY_STATE.OPEN_STATE) {
+        return;
       }
-    });
+      client.send(JSON.stringify(response));
+    };
+    source$.subscribe(handleMessage);
   }
 
   public bindMessageHandler(
@@ -108,7 +110,9 @@ export class WsAdapter implements WebSocketAdapter {
   }
 
   public bindErrorHandler(server) {
-    server.on(CONNECTION_EVENT, ws => ws.on(ERROR_EVENT, err => this.logger.error(err)));
+    server.on(CONNECTION_EVENT, ws =>
+      ws.on(ERROR_EVENT, err => this.logger.error(err)),
+    );
     server.on(ERROR_EVENT, err => this.logger.error(err));
     return server;
   }