Skip to content

Commit

Permalink
netprio_cgroup: remove task_struct parameter from sock_update_netprio()
Browse files Browse the repository at this point in the history
The callers always pass current to sock_update_netprio().

Signed-off-by: Li Zefan <[email protected]>
Acked-by: Neil Horman <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
lizf-os authored and davem330 committed Apr 9, 2013
1 parent 211d2f9 commit 6ffd464
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions include/net/netprio_cgroup.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ struct cgroup_netprio_state {
struct cgroup_subsys_state css;
};

extern void sock_update_netprioidx(struct sock *sk, struct task_struct *task);
extern void sock_update_netprioidx(struct sock *sk);

#if IS_BUILTIN(CONFIG_NETPRIO_CGROUP)

Expand Down Expand Up @@ -68,7 +68,7 @@ static inline u32 task_netprioidx(struct task_struct *p)
return 0;
}

#define sock_update_netprioidx(sk, task)
#define sock_update_netprioidx(sk)

#endif /* CONFIG_NETPRIO_CGROUP */

Expand Down
2 changes: 1 addition & 1 deletion net/core/scm.c
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ void scm_detach_fds(struct msghdr *msg, struct scm_cookie *scm)
/* Bump the usage count and install the file. */
sock = sock_from_file(fp[i], &err);
if (sock) {
sock_update_netprioidx(sock->sk, current);
sock_update_netprioidx(sock->sk);
sock_update_classid(sock->sk);
}
fd_install(new_fd, get_file(fp[i]));
Expand Down
6 changes: 3 additions & 3 deletions net/core/sock.c
Original file line number Diff line number Diff line change
Expand Up @@ -1319,12 +1319,12 @@ EXPORT_SYMBOL(sock_update_classid);
#endif

#if IS_ENABLED(CONFIG_NETPRIO_CGROUP)
void sock_update_netprioidx(struct sock *sk, struct task_struct *task)
void sock_update_netprioidx(struct sock *sk)
{
if (in_interrupt())
return;

sk->sk_cgrp_prioidx = task_netprioidx(task);
sk->sk_cgrp_prioidx = task_netprioidx(current);
}
EXPORT_SYMBOL_GPL(sock_update_netprioidx);
#endif
Expand Down Expand Up @@ -1354,7 +1354,7 @@ struct sock *sk_alloc(struct net *net, int family, gfp_t priority,
atomic_set(&sk->sk_wmem_alloc, 1);

sock_update_classid(sk);
sock_update_netprioidx(sk, current);
sock_update_netprioidx(sk);
}

return sk;
Expand Down

0 comments on commit 6ffd464

Please sign in to comment.