General Improvement PR #ilostcount #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code should never be guided by exceptions. Also fixed the top-priority constructor.
Use a second executor for the close queue (does it even really need to have its own thread?) Specify a custom ThreadFactory for the main executor that assigns a meaningful name to the threads Use wait/notify to handle pausing Change the run method to not require a try/catch block Don't push a finished event for a sound that was cancelled Fix a typo Remove several unneeded try/catch blocks
Also, the set method doesn't need a type parameter.
|
That's some sexy stuff right there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.